Skip to content

[mkdocs] feat: add listen multisig txt tutorial (websockets) - #955

Merged
segfaultxavi merged 2 commits into
NemProject:new-docsfrom
zero4862:docs-listen-multisig-tx-websockets
Aug 3, 2026
Merged

[mkdocs] feat: add listen multisig txt tutorial (websockets)#955
segfaultxavi merged 2 commits into
NemProject:new-docsfrom
zero4862:docs-listen-multisig-tx-websockets

Conversation

@zero4862

Copy link
Copy Markdown

Adds Listening to Multisig Transaction Flow tutorial.

@zero4862
zero4862 requested a review from segfaultxavi July 30, 2026 15:25

The subscriptions use the IDs `id-0`, `id-1` and `id-2`, which identify them when the code unsubscribes at the end.

!!! note "Message handling differences"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While working on the multisig transaction flow tutorial, I figured out how to make the JavaScript and Python message handling more consistent while still keeping each language idiomatic. As a result, the examples now look much more similar side by side.

I also updated the listen-transaction-flow tutorial to match in this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yeah, it reads much better.

The issue is that now the actual await done is not shown in any snippet. But that is going to be hard to fix, and this is an intermediate tutorial, so readers will be read the read the whole code and understand the flow.

@zero4862 zero4862 added the Change: Documentation Changes to documentation only. label Jul 30, 2026
@segfaultxavi
segfaultxavi force-pushed the docs-listen-multisig-tx-websockets branch from 3e108c2 to 4eed3b1 Compare August 3, 2026 18:03

@segfaultxavi segfaultxavi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to go back to previous tutorials and improve them!

I've just added the same comment regarding the 2-of-2 multisig as in the previous PR.
(And some nitpicks)

@segfaultxavi
segfaultxavi merged commit b2ed91e into NemProject:new-docs Aug 3, 2026
0 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Change: Documentation Changes to documentation only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants