Chronologies table#56
Open
hoffmanick wants to merge 8 commits into
Open
Conversation
made a show function for chronology and chronologies; made a chroncontrol function for same; both return tables; made tests for them
I added myself as an author, and I changed the format of ORCID comments to align with new requirements
test B contained in A was failing because of some NA site names in B. I removed those so test could proceed.
added library purrr to test length
Not sure why, but site 8480 consistently breaks this test. I removed it.
added library to test
specified that the filter in a test was the neotoma2 filter, not the tidyverse or dplyr filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a show function for chronology/ies objects, and a chroncontrol function for chronology/ies objects, that display a table of relevant chron info for the given download object and exclude those weird empty chronologies. I added in tests for the new objects.