This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Add Go Client (Worker) Implementation#133
Merged
v1r3n merged 10 commits intoNetflix:devfrom Mar 23, 2017
Merged
Conversation
added 9 commits
March 22, 2017 10:59
v1r3n
reviewed
Mar 23, 2017
client/go/conductorworker.go
Outdated
|
|
||
| // wait infinitely while the go routines are running | ||
| if wait { | ||
| for { |
Contributor
There was a problem hiding this comment.
It seems this might take up 100% cpu. The blow might be better.
select {}Some more references:
http://blog.sgmansfield.com/2016/06/how-to-block-forever-in-go/
Contributor
Author
There was a problem hiding this comment.
This is a good catch. I verified spawning 100 goroutines for multiple task pollers with the infinite for loop and saw the 100% usage in top. After changing to select this was no longer the case.
v1r3n
added a commit
that referenced
this pull request
Apr 11, 2017
* Add Go Client (Worker) Implementation (#133) * Worker interfaces in Go * Move external dependency of httpclient inside package (#135) Http Client * * Add optional tasks * Fix for taskId not getting replaced for simple tasks in task input calculation * License headers for go client * fixed the sink name * gradle updates (#147) * 1.7.1 (#151) * capture the event payload in the task's output * prefix the internal events with conductor when using dynamic event names * Update queue name * add more details to action processor and workflow executor * more details and streamlined key names * do not add policies if empty * * allow referencing more task parameters in input/outputs * Unit tests * handle null * minor changes and code cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.