This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Conversation
Contributor
v1r3n
commented
Apr 27, 2017
v1r3n
commented
- Execute system tasks asynchronously
- Allow limiting concurrent execution of tasks (early beta)
Handle the case where sub workflow might not have started when trying to cancel
…rrency (#185) * Asynchronous execution of system tasks * Allow limiting the number of tasks in progress by task def name
boney9
approved these changes
Apr 28, 2017
vikramsingh2104
approved these changes
Apr 28, 2017
| return false; | ||
| } | ||
| } | ||
| return false; |
Contributor
There was a problem hiding this comment.
The method basically becomes a no-op, where has this functionality to start again moved?
| return Collections.emptyList(); | ||
| if(edao.exceedsInProgressLimit(task)) { | ||
| continue; | ||
| } |
Contributor
There was a problem hiding this comment.
Why do we need to check the limit while polling?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.