Update getting started local tutorial to clarify required JDK version.#607
Open
jpittis wants to merge 1 commit intoNetflix:masterfrom
Open
Update getting started local tutorial to clarify required JDK version.#607jpittis wants to merge 1 commit intoNetflix:masterfrom
jpittis wants to merge 1 commit intoNetflix:masterfrom
Conversation
See Netflix#604 for context. The Mantis project does not presently compile will all JDK versions larger or equal to 8.
jpittis
requested review from
Andyz26,
calvin681,
fdc-ntflx,
hmitnflx,
jeffchao,
markcho,
nickmahilani,
piygoyal and
sundargates
as code owners
jpittis
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
reviewed
Dec 13, 2023
| ## Prerequisites | ||
|
|
||
| JDK 8 or higher | ||
| JDK 8 (newer versions may not be supported) |
Contributor
There was a problem hiding this comment.
It would be better to use the java toolchain support in gradle to define this directly and get rid of these instructions altogether. https://docs.gradle.org/current/userguide/toolchains.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
See #604 for context. The Mantis project does not presently compile will all JDK versions larger or equal to 8.
Note that I haven't tested for at which point the incompatibility begins, just that JDK17 doesn't work.
I added a tip box for the tip about JDK selection tooling that @calvin681 gave me in #604.
I also ran through the rest of the guide and confirmed it's functional (with a slight adjustment to the wording around the port number selection incase that trips anyone up).
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests