Skip to content

fix: resolve Docker build workflow warnings #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrix060 merged 1 commit into from
Apr 10, 2026
Merged

fix: resolve Docker build workflow warnings #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/docker-build-push-dockerhub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down Expand Up @@ -151,7 +152,7 @@ jobs:
bash "$SCRIPT_PATH"

- name: Build and push
uses: NethermindEth/github-action-image-build-and-push@fefef12a2baef6d339fb4b244b4cd45c40146161
uses: NethermindEth/github-action-image-build-and-push@972f8cf69d5ede0a0cb9d7cc953fa902538e2ffa
with:
registry: "dockerhub"
image_name: ${{ inputs.repo_name }}/${{ inputs.image_name }}
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/docker-build-push-jfrog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down Expand Up @@ -184,7 +185,7 @@ jobs:
bash "$SCRIPT_PATH"

- name: Build and push
uses: NethermindEth/github-action-image-build-and-push@fefef12a2baef6d339fb4b244b4cd45c40146161
uses: NethermindEth/github-action-image-build-and-push@972f8cf69d5ede0a0cb9d7cc953fa902538e2ffa
with:
registry: "artifactory"
image_name: ${{ steps.env-vars.outputs.IMAGE_NAME }}
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/docker-promote-dockerhub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ on:
description: "Docker Hub password"
required: true

permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
promote:
name: Promote Docker image
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/docker-promote-jfrog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ on:
required: false
default: false

Copilot AI Apr 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputs.skip_attest is declared as type: string but its default is the boolean false, and later the workflow compares it to the string 'true'. This type/default mismatch can cause reusable-workflow validation errors or unexpected coercion. Consider making skip_attest a boolean input (with default: false) and updating the if: expression accordingly, or keep it as a string and quote the default (e.g. "false") and document accepted values.

Suggested change
default: false
default: "false"

Copilot uses AI. Check for mistakes.

permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
promote:
name: Promote Docker image
Expand Down
1 change: 1 addition & 0 deletions examples/docker/build-push-dockehub-complete.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 1 addition & 0 deletions examples/docker/build-push-dockerhub-simple.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 1 addition & 0 deletions examples/docker/build-push-jfrog-complete.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 1 addition & 0 deletions examples/docker/build-push-jfrog-simple.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 1 addition & 0 deletions examples/docker/docker-push-multiple-jfrog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 1 addition & 0 deletions examples/docker/promote-dockerhub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ concurrency:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 1 addition & 0 deletions examples/docker/promote-jfrog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ concurrency:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
Loading