Skip to content

fix: remove artifact-metadata:write from reusable workflows #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrix060 merged 1 commit into from
Apr 10, 2026
Merged

fix: remove artifact-metadata:write from reusable workflows #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/docker-build-push-dockerhub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docker-build-push-jfrog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ on:
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/docker-promote-dockerhub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,6 @@ on:
description: "Docker Hub password"
required: true

Copilot AI Apr 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow-level permissions block was removed entirely. This workflow runs actions/attest-build-provenance, which needs id-token: write and attestations: write (and contents: read for checkout). If callers don’t set these permissions explicitly, the workflow will fail at runtime; this is a broader breaking change than just removing artifact-metadata: write. Consider re-adding the minimal required permissions here and only removing artifact-metadata: write.

Suggested change
permissions:
contents: read
id-token: write
attestations: write

Copilot uses AI. Check for mistakes.
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
promote:
name: Promote Docker image
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/docker-promote-jfrog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,6 @@ on:
required: false
default: false

Copilot AI Apr 10, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow-level permissions block was removed entirely. This reusable workflow uses OIDC (via jfrog/setup-jfrog-cli) and actions/attest-build-provenance, which require at least id-token: write and attestations: write (and typically contents: read). Without setting these here, callers must provide them explicitly, turning this into a breaking change and potentially causing runtime failures rather than a clear permissions validation error. Consider restoring the permissions block and only dropping artifact-metadata: write (per PR intent), or explicitly moving the required permissions to a job-level permissions stanza with the same effect.

Suggested change
permissions:
contents: read
id-token: write
attestations: write

Copilot uses AI. Check for mistakes.
permissions:
id-token: write
attestations: write
artifact-metadata: write
contents: read

jobs:
promote:
name: Promote Docker image
Expand Down
Loading