refactor: replace two-stage CSV parsing with a single-pass streaming pipeline to reduce memory usage#47
Open
refactor: replace two-stage CSV parsing with a single-pass streaming pipeline to reduce memory usage#47
Conversation
…pipeline to reduce memory usage
…ct video timestamp logic into a dedicated utility class.
… to CsvIngestParser for robust telemetry synchronization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a single-pass streaming architecture for the telemetry CSV parser to prevent OutOfMemoryError (OOM) crashes on large 1hr+ Litchi logs. Previously, the parser loaded the entire CSV into memory as a List<List> before parsing (resulting in 1.4M+ allocated objects for large flights).
CsvIngestParser.kt Refactor: Merged CsvIngest and CsvParser into a combined streaming API (streamAndParse). We now read the file lazily using a BufferedReader, map rows to telemetry objects on the fly, and filter by start time natively—avoiding holding unused rows in memory.
TelemetryPreprocessor.kt: Updated the preprocessing pipeline to utilize the new streamAndParse method, drastically reducing the memory footprint during Stage 1-2.