sequoia-nixbld-user-migration: disable trace mode#11476
Merged
tomberek merged 1 commit intoNixOS:masterfrom Sep 11, 2024
Merged
sequoia-nixbld-user-migration: disable trace mode#11476tomberek merged 1 commit intoNixOS:masterfrom
tomberek merged 1 commit intoNixOS:masterfrom
Conversation
Was hoping to leave this enabled for a little while as core community members test this script out, but Apple's aggressive release timeline for macOS 15 Sequoia has caught us off-guard here. It's probably not ideal for a general audience if the script spews all of this output--and people can still force bash to run in trace mode if we really need to debug a problem.
emilazy
approved these changes
Sep 11, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
I got explicit feedback that the set -x output was noisy and confusing from @mjm while testing nix-darwin/nix-darwin#1069 and I believe @reckenrode also expressed the same thing when he did the migration on his system.
Since we’re rushing to expose this script to as many people as possible before the Sequoia release, I wholeheartedly endorse making its output more human‐readable.
tomberek
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was hoping to leave this enabled for a little while as core community members test the UID migration script out, but Apple's aggressive release timeline (i.e., Monday Sept 16--the earliest in over a decade) for macOS 15 Sequoia has caught us off-guard here.
It's probably not ideal for a general audience if the script spews all of this output--and people can still force bash to run in trace mode (i.e., with
bash -xor even via env as detailed in https://unix.stackexchange.com/a/645145/65153) if we really need to debug a problem.cc @emilazy
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.