roslyn-ls: include razor extensions

[konradmalik]

Integrate razor extensions (needed for cohosting) since rzls will be depreciated in favor of using cohosting.

See:

• roslyn-ls: 5.3.0-2.25603.1 -> 5.3.0-2.25604.5 #471327 (comment)
• Razor Support seblyng/roslyn.nvim#267
• roslyn nixpkgs does not include .razorExtensions seblyng/roslyn.nvim#272

[konradmalik]

@zspher from what I see in roslyn.nvim:

    if razor_extension_path ~= nil then
        cmd = vim.list_extend(cmd, {
            "--razorSourceGenerator="
                .. vim.fs.joinpath(razor_extension_path, "Microsoft.CodeAnalysis.Razor.Compiler.dll"),
            "--razorDesignTimePath="
                .. vim.fs.joinpath(razor_extension_path, "Targets", "Microsoft.NET.Sdk.Razor.DesignTime.targets"),
            "--extension",
            vim.fs.joinpath(razor_extension_path, "Microsoft.VisualStudioCode.RazorExtension.dll"),
        })
    end
    return cmd

means:

• This plugin currently only handles roslyn installed through mason (razor_extension_path relies on $MASON), so whatever we do in nixpkgs it won't "just work" with the current state of the plugin
• in that case user would need to manually add

          cmd = vim.list_extend(cmd, {
              "--razorSourceGenerator="
                  .. vim.fs.joinpath(razor_extension_path, "Microsoft.CodeAnalysis.Razor.Compiler.dll"),
              "--razorDesignTimePath="
                  .. vim.fs.joinpath(razor_extension_path, "Targets", "Microsoft.NET.Sdk.Razor.DesignTime.targets"),
              "--extension",
              vim.fs.joinpath(razor_extension_path, "Microsoft.VisualStudioCode.RazorExtension.dll"),
          })

  in their config
• This means, that the result we'd like to have in nixpkgs is to have a way to easily discover the location of those 3 files.
• A potential solution would be to include them in ${pkgs.roslyn-ls}/lib/razor folder. Then on runtime, users could point there like so:

  -- rough pseudocode
  local razor_extension_path = vim.system("which Microsoft.CodeAnalysis.LanguageServer") .. "../lib/razor"

• later, roslyn.nvim could be extended to auto-detect this not only for mason installations, but also for nixpkgs

Does this make sense?

[zspher]

Hi, thanks for looking into this. I understand, I've been using something like the above solution but with vscode-extensions.ms-dotnettools.csharp and overriding vim.lsp.config.

[wadsaek]

Hi, thanks for looking into this. I understand, I've been using something like the above solution but with vscode-extensions.ms-dotnettools.csharp and overriding vim.lsp.config.

@zspher, could you please explain how do you do that? I'd love to see your config

[zspher]

hi just saw this.
to get vscode-extensions.ms-dotnettools.csharp working with neovim:

1. expose binaries to PATH using the ff package file and then install

{
  stdenvNoCC,
  ms-dotnettools, # custom updated to v2.110.4
}:
stdenvNoCC.mkDerivation {
  pname = "csharp-tools";
  version = "0.1";

  src = ./.;

  buildInputs = [
    ms-dotnettools
  ];

  installPhase =
    let
      root = "${ms-dotnettools}/share/vscode/extensions/ms-dotnettools.csharp";
    in
    ''
      runHook preInstall

      mkdir -p $out/bin
      mkdir -p $out/lib

      ln -s ${root}/.roslyn/Microsoft.CodeAnalysis.LanguageServer $out/bin/roslyn-ls

      runHook postInstall
    '';
}

2. use the ff. neovim config

  {
    "seblyng/roslyn.nvim",
    ft = { "cs", "razor" },
    ---@module 'roslyn.config'
    ---@type RoslynNvimConfig
    opts = {
      silent = true,
      filewatching = "off",
    },
    init = function()
      vim.filetype.add {
        extension = {
          razor = "razor",
          cshtml = "razor",
        },
      }
      local razor = vim.fs.joinpath(
        vim.fn.fnamemodify(vim.fn.resolve(vim.fn.exepath "roslyn-ls"), ":h:h"),
        ".razorExtension"
      )
      local cmd = {
        "roslyn-ls",
        "--stdio",
        "--logLevel=Information",
        "--extensionLogDirectory=" .. vim.fs.dirname(vim.lsp.get_log_path()),
        "--razorSourceGenerator="
          .. vim.fs.joinpath(razor, "Microsoft.CodeAnalysis.Razor.Compiler.dll"),
        "--razorDesignTimePath=" .. vim.fs.joinpath(
          razor,
          "Targets",
          "Microsoft.NET.Sdk.Razor.DesignTime.targets"
        ),
        "--extension",
        vim.fs.joinpath(razor, "Microsoft.VisualStudioCode.RazorExtension.dll"),
      }
      vim.lsp.config("roslyn", {
        cmd = cmd,
      })
    end,
  },