Cleanups and maintainerships collection

[SuperSandro2000]

Motivation for this change

Now I feel comfortable to merge this. Moving the bc change to a PR which targets staging.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112855 run on x86_64-linux 1

2 packages failed to build and already failed to build on hydra master:

• spring: log https://termbin.com/4gxj
• springLobby: log was empty

52 packages built:

• adapta-gtk-theme
• asciidocFull (asciidoc-full)
• asciidoc-full-with-plugins
• btrbk
• ccache
• ccacheStdenv
• ccacheWrapper
• cdimgtools
• chrome-gnome-shell
• clevis
• cod
• colordiff
• diffoscope
• disorderfs
• du-dust
• duf
• flexget
• gnome3.gnome-session
• gnome3.gnome-shell
• gnome3.gnome-terminal
• gnome3.gnome-tweak-tool
• gnome3.pomodoro
• gnomeExtensions.easyScreenCast
• gnomeExtensions.gsconnect
• gnomeExtensions.night-theme-switcher
• pup (go-pup)
• gron
• herbstluftwm
• knightos-genkfs
• knightos-kimg
• knightos-mkrom
• knightos-mktiupgrade
• luksmeta
• ncpamixer
• pantheon.elementary-session-settings
• pkgdiff
• python37Packages.nmigen-boards
• python37Packages.transmissionrpc
• python37Packages.yq
• python38Packages.nmigen-boards
• python38Packages.transmissionrpc
• yq (python38Packages.yq)
• python39Packages.nmigen-boards
• python39Packages.transmissionrpc
• python39Packages.yq
• ranger
• rep
• sourceHighlight
• tang
• tig
• udiskie
• wdiff

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

btrbk:

Details

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/etc' doesn't match anything in file './doc/Makefile'
substituteStream(): WARNING: pattern '/bin/date' doesn't match anything in file 'contrib/cron/btrbk-mail'
substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'contrib/cron/btrbk-mail'
substituteStream(): WARNING: pattern '$btrbk' doesn't match anything in file 'contrib/cron/btrbk-mail'

Please check the offending substituteInPlace for typos or changes in source.
warning: unclear-gpl
gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

Near pkgs/tools/backup/btrbk/default.nix:47:5:

   |
47 |     license = licenses.gpl3;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: build-tools-in-build-inputs
perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/tools/backup/btrbk/default.nix:15:3:

   |
15 |   buildInputs = with perlPackages; [ perl DateCalc ];
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

spring:

Details

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern 'static constexpr const GLubyte* qcriProcName' doesn't match anything in file './rts/Rendering/GL/myGL.cpp'

Please check the offending substituteInPlace for typos or changes in source.
warning: attribute-typo
A likely typo in rev argument was found, did you mean meta, src or srcs?

Near pkgs/games/spring/default.nix:12:3:

   |
12 |   rev = "f266c8107b3e5dda5a78061ef00ca0ed8736d6f2";
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: unclear-gpl
gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/games/spring/default.nix:60:5:

   |
60 |     license = licenses.gpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
warning: build-tools-in-build-inputs
p7zip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/games/spring/default.nix:44:3:

   |
44 |   buildInputs = [ lzma boost libdevil zlib p7zip openal libvorbis freetype SDL2
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: build-tools-in-build-inputs
which is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/games/spring/default.nix:44:3:

   |
44 |   buildInputs = [ lzma boost libdevil zlib p7zip openal libvorbis freetype SDL2
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md

[SuperSandro2000]

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112855 run on x86_64-darwin 1

2 packages marked as broken and skipped:

• btrbk
• udiskie

1 package failed to build and already failed to build on hydra master:

• diffoscope: log was empty

3 packages failed to build and are new build failures:

• python37Packages.nmigen-boards: log was empty
• python38Packages.nmigen-boards: log was empty
• python39Packages.nmigen-boards: log was empty

36 packages built:

• asciidoc-full
• asciidoc-full-with-plugins
• ccache
• ccacheStdenv
• cdimgtools
• cod
• colordiff
• du-dust
• duf
• flexget
• gron
• img2pdf (python38Packages.img2pdf)
• knightos-genkfs
• knightos-kimg
• knightos-mktiupgrade
• pkgdiff
• pup
• python37Packages.img2pdf
• python37Packages.pikepdf
• python37Packages.python-xmp-toolkit
• python37Packages.transmissionrpc
• python37Packages.yq
• python38Packages.pikepdf
• python38Packages.python-xmp-toolkit
• python38Packages.transmissionrpc
• yq (python38Packages.yq)
• python39Packages.img2pdf
• python39Packages.pikepdf
• python39Packages.python-xmp-toolkit
• python39Packages.transmissionrpc
• python39Packages.yq
• ranger
• rep
• sourceHighlight
• tig
• wdiff

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

img2pdf:

Details

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

• Tell pytest(CheckHook) where to find the tests included in the package
• Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
• If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

python37Packages.img2pdf:

Details

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

• Tell pytest(CheckHook) where to find the tests included in the package
• Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
• If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
warning: unclear-gpl
lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

Near pkgs/development/python-modules/img2pdf/default.nix:21:5:

   |
21 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

python39Packages.img2pdf:

Details

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

• Tell pytest(CheckHook) where to find the tests included in the package
• Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
• If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
warning: unclear-gpl
lgpl2 is a deprecated license, check if project uses lgpl2Plus or lgpl2Only and change meta.license accordingly.

Near pkgs/development/python-modules/img2pdf/default.nix:21:5:

   |
21 |     license = licenses.lgpl2;
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md

ranger:

Details

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/bin/echo' doesn't match anything in file 'ranger/data/scope.sh'
substituteStream(): WARNING: pattern '/usr/share' doesn't match anything in file 'doc/config/rc.conf'

Please check the offending substituteInPlace for typos or changes in source.