catfs: unstable-2020-03-21 -> 0.9.0#205379
Merged
jonringer merged 2 commits intoNixOS:masterfrom Dec 17, 2022
tjni:catfs
Merged
catfs: unstable-2020-03-21 -> 0.9.0#205379jonringer merged 2 commits intoNixOS:masterfrom tjni:catfs
jonringer merged 2 commits intoNixOS:masterfrom
tjni:catfs
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1564 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/kahing/catfs/releases/tag/v0.9.0
This broke when Rust upgraded in #199664. Rust has added a new default lint in rust-lang/rust#97739 that requires code changes upstream.
I've added a patch that keeps the current behavior and fixes the lint warning. Not upstreaming because it's not obvious to me that it's the proper upstream fix, but the current behavior doesn't look harmful. We can monitor kahing/catfs#71 for a full resolution.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes