rsync: fix missing ipv6 support

[bobrik]

Description of changes

Added a patch to apply RsyncProject/rsync#558.

Somehow aarch64-linux is okay:

• https://hydra.nixos.org/build/242874385/nixlog/1256

While aarch64-darwin is not:

• https://hydra.nixos.org/build/243173677/nixlog/1

I think it broke with clang-16:

ivan@vm:~/projects/rsync$ clang-15 -o derp -g -O2 -Wall -W derp.c
derp.c:4:1: warning: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
main()
^
int
1 warning generated.

ivan@vm:~/projects/rsync$ clang-16 -o derp -g -O2 -Wall -W derp.c
derp.c:4:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
main()
^
int
1 error generated.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[ghost]

this is similar to Issue #276961.
will need to target staging as there are too many rebuilds for master. see: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

[bobrik]

Can we gate it to just darwin and target master still or would it be still to big in terms of rebuilds?

[ghost]

Can we gate it to just darwin and target master still or would it be still to big in terms of rebuilds?

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-causing-mass-rebuilds says over 500 is considered a mass rebuild event, so seems like it needs to target staging regardless.

[bobrik]

I asked GitHub to target staging + rebased and force pushed it. Same as always, there was a weird intermediate state with lots of unrelated changes that pulled many reviewers. I'm not sure if there's a proper way to do this in the same PR, but I'm happy to be pointed at the right docs for the next time.

[ghost]

I think that means you have to close this PR and try again.
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#something-went-wrong-and-a-lot-of-people-were-pinged