nixos/network-interfaces: Add support for multiple ipv4 / ipv6 addresses

[wkennington]

No description provided.

[wkennington]

TODO: Fix broken nixos tests
TODO: Add a stop script to the interface configuration to flush nixos configured addresses.

[wkennington]

Stop script done and tested, TODO broken tests.

[wkennington]

Should be done, testing would be appreciated but this works on all of my multi-interface, multi-ip machines.

[Mathnerd314]

Shouldn't this also filter out ipv6 interfaces?

[wkennington]

Well, it really only make sense in the case of ipv4 as you could conceivably want a static + dhcp ipv6 address. I think we should really force the user to choose if they want dhcp or not. Not try and figure it out for them.

[wkennington]

@edolstra Could you look over this before I get too entrenched in using it and need to make changes?

[7c6f434c]

Is it necessary to make the old way defunct? Maybe it should complain using trace, but define a single address using the new syntax?

[robberer]

Would be really great if this PR could be applied. I'm waiting for it since wkennington opened this PR.

[peti]

Yes, this change looks quite useful.

[wkennington]

I could fairly trivially support the old syntax with the exception of the subnetMask line which I assume isn't very common anymore. I just wanted to force a migration to the new syntax so users were more aware of the changes.

[aristidb]

Yes compatibility please. If somebody needs multiple IPs he will find the
new syntax surely.
Am 30.08.2014 16:14 schrieb "William A. Kennington III" <
notifications@github.com>:

I could fairly trivially support the old syntax with the exception of the
subnetMask line which I assume isn't very common anymore. I just wanted to
force a migration to the new syntax so users were more aware of the changes.

—
Reply to this email directly or view it on GitHub
#3182 (comment).

[wkennington]

I think that should do it.

[7c6f434c]

Let's hope it works with real-world old-style configurations…

[robberer]

There is an issue with this patch:

error: attribute `address' missing, at /etc/nixos/nixpkgs/nixos/modules/tasks/network-interfaces.nix:630:32

[rbvermaa]

I have reverted for now, because it seems to break even simple configurations. The feature sounds nice though.

[rbvermaa]

Also, please in next PR also add the following (also reverted) commit : 704e91b

[rbvermaa]

I suspect the issue might be an interaction with nixpkgs/nixos/modules/programs/virtualbox.nix