Skip to content

test driver: normalize callpackage call#468717

Merged
roberth merged 1 commit intoNixOS:staging-nixosfrom
tfc:test-driver-callpackage
Dec 9, 2025
Merged

test driver: normalize callpackage call#468717
roberth merged 1 commit intoNixOS:staging-nixosfrom
tfc:test-driver-callpackage

Conversation

@tfc
Copy link
Contributor

@tfc tfc commented Dec 7, 2025

This PR puts the test driver package function into package normal form to facilitate easier override of the python version of everything.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@tfc tfc requested review from Ma27 and roberth December 7, 2025 16:16
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules labels Dec 7, 2025
@roberth
Copy link
Member

roberth commented Dec 7, 2025

I'm not much of a python maintainer, but no special concerns from me as someone who has worked a bit nixos/lib/testing.

Something we probably should take into account is infra has set up a staging-nixos branch for these kinds of rebuilds. Could you target that branch?

@tfc tfc force-pushed the test-driver-callpackage branch from b1594ea to 0024056 Compare December 8, 2025 20:15
@tfc
Copy link
Contributor Author

tfc commented Dec 8, 2025

Something we probably should take into account is infra has set up a staging-nixos branch for these kinds of rebuilds. Could you target that branch?

done

github-actions[bot]

This comment was marked as resolved.

@tfc tfc changed the base branch from master to staging-nixos December 8, 2025 20:15
@nixpkgs-ci nixpkgs-ci bot closed this Dec 8, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 8, 2025
@github-actions github-actions bot dismissed their stale review December 8, 2025 20:16

All good now, thank you!

@tfc
Copy link
Contributor Author

tfc commented Dec 8, 2025

@roberth hmmm i don't understand the CI error. it says the PR contains commits of a different base, although i literally rebased onto the latest staging-nixos before i switched the PR base.

oh nvm it looks like that was from some inbetween state.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 8, 2025
@roberth roberth added this pull request to the merge queue Dec 9, 2025
Merged via the queue into NixOS:staging-nixos with commit fd8c29a Dec 9, 2025
39 of 47 checks passed
jfroche added a commit to numtide/nix-vm-test that referenced this pull request Dec 22, 2025
Since the NixOS/nixpkgs#468717 change to the test-driver we have to use python3Packages to call it.
zimbatm pushed a commit to numtide/nix-vm-test that referenced this pull request Dec 22, 2025
Since the NixOS/nixpkgs#468717 change to the test-driver we have to use python3Packages to call it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants