Conversation
Creates space for other test suites in the `test` directory, such as the golden test I'm about to add.
These test (and document) what code generation currently looks like for various Servant API constructors.
Query flags are the Http equivalent of booleans. You can either set them or you cannot. Currently the generated ruby code treats them as values: You pass in a string and it gets added to the query string. This ensures query flags in a servant API are modeled as booleans in the generated ruby code.
stoeffel
suggested changes
Oct 22, 2019
stoeffel
left a comment
stoeffel
left a comment
There was a problem hiding this comment.
code looks great, but we use the branch next-version in our codebase. maybe we should merge that into master and use master, since the upstream repo still has a few prs from us open.
Author
|
@stoeffel I merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated ruby code for
QueryFlags in Servant contains an error. This PR fixes it, and adds some golden tests too!