Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions src/Servant/Ruby.hs
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public indent req =
]
++ cleanCaptures
++
[ Just $ " req = Net::HTTP::" <> method <> ".new(" <> functionName <> "_uri(" <> argsStr <> "))"
[ Just $ " req = Net::HTTP::" <> method <> ".new(" <> functionName <> "_uri(" <> callArgsStr <> "))"
]
++ requestHeaders
++
Expand Down Expand Up @@ -286,16 +286,22 @@ public indent req =
]

argsStr :: Text
argsStr = T.intercalate ", " $ snake <$> args
argsStr = T.intercalate ", " args

callArgsStr :: Text
callArgsStr = T.intercalate ", " callArgs

callArgs :: [Text]
callArgs = captures ++ (paramToCallArg <$> queryparams)

allArgsStr :: Text
allArgsStr = T.intercalate ", " $ snake <$> (args ++ bodyAndHeader)
allArgsStr = T.intercalate ", " (args ++ bodyAndHeader)

args :: [Text]
args = captures ++ ((^. queryArgName.argPath) <$> queryparams)
args = captures ++ (paramToArg <$> queryparams)

bodyAndHeader :: [Text]
bodyAndHeader = body ++ headerArgs
bodyAndHeader = snake <$> (body ++ headerArgs)

segments :: [Segment NoContent]
segments = filter isCapture paths
Expand All @@ -306,7 +312,7 @@ public indent req =
queryparams = req ^.. reqUrl.queryStr.traverse

captures :: [Text]
captures = view argPath . captureArg <$> segments
captures = fmap snake $ view argPath . captureArg <$> segments

body :: [Text]
body =
Expand Down Expand Up @@ -389,6 +395,24 @@ paramToStr qarg =
key = qarg ^. queryArgName.argName._PathSegment
val = snake key

paramToArg :: QueryArg f -> Text
paramToArg qarg =
case qarg ^. queryArgType of
Normal -> snake name
Flag -> snake name <> ": false"
List -> snake name
where
name = qarg ^. queryArgName.argPath

paramToCallArg :: QueryArg f -> Text
paramToCallArg qarg =
case qarg ^. queryArgType of
Normal -> snake name
Flag -> snake name <> ": " <> snake name
List -> snake name
where
name = qarg ^. queryArgName.argPath

snake :: Text -> Text
snake = T.pack . quietSnake . T.unpack

Expand Down
6 changes: 3 additions & 3 deletions test/golden/expected/query_flag.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ def initialize(origin, timeout = nil)
@http.use_ssl = @origin.scheme == 'https'
end

def get_uri(beetle)
def get_uri(beetle: false)
URI("#{@origin}?#{beetle ? 'beetle' : ''}")
end

def get(beetle)
req = Net::HTTP::Get.new(get_uri(beetle))
def get(beetle: false)
req = Net::HTTP::Get.new(get_uri(beetle: beetle))

@http.request(req)
end
Expand Down