Fix/command streaming#15
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances command execution by adding real-time streaming support, and it adjusts logging and import statements accordingly while updating linting rule severity.
- Added onStdout and onStderr callbacks in the command executor for real-time streaming
- Updated Unity Hub command executions to utilize these callbacks
- Fixed an import path in unityEditor and lowered ESLint rule severity for prefer-nullish-coalescing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/commandExecutor.ts | Introduces streaming callbacks and adjusts buffering accordingly |
| src/unityHub.ts | Updates command execution to use the new streaming callbacks |
| src/unityEditor.ts | Corrects the relative import for the security module |
| eslint.config.js | Changes ESLint rule for nullish coalescing from error to warn |
Comments suppressed due to low confidence (1)
src/utils/commandExecutor.ts:25
- [nitpick] Consider renaming 'streamOutput' to 'shouldStreamOutput' to more clearly indicate its boolean nature.
const streamOutput = options.onStdout || options.onStderr;
|
🎉 This PR is included in version 1.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.7-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #13