Skip to content

Fix/command streaming#15

Merged
MtMath merged 4 commits into
release/v1.0.7from
fix/command-streaming
May 3, 2025
Merged

Fix/command streaming#15
MtMath merged 4 commits into
release/v1.0.7from
fix/command-streaming

Conversation

@MtMath
Copy link
Copy Markdown
Member

@MtMath MtMath commented May 3, 2025

close #13

@MtMath MtMath added bug Something isn't working developer experience labels May 3, 2025
@MtMath MtMath requested a review from Copilot May 3, 2025 02:47
@MtMath MtMath self-assigned this May 3, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances command execution by adding real-time streaming support, and it adjusts logging and import statements accordingly while updating linting rule severity.

  • Added onStdout and onStderr callbacks in the command executor for real-time streaming
  • Updated Unity Hub command executions to utilize these callbacks
  • Fixed an import path in unityEditor and lowered ESLint rule severity for prefer-nullish-coalescing

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/utils/commandExecutor.ts Introduces streaming callbacks and adjusts buffering accordingly
src/unityHub.ts Updates command execution to use the new streaming callbacks
src/unityEditor.ts Corrects the relative import for the security module
eslint.config.js Changes ESLint rule for nullish coalescing from error to warn
Comments suppressed due to low confidence (1)

src/utils/commandExecutor.ts:25

  • [nitpick] Consider renaming 'streamOutput' to 'shouldStreamOutput' to more clearly indicate its boolean nature.
const streamOutput = options.onStdout || options.onStderr;

Comment thread eslint.config.js
@MtMath MtMath merged commit f0b4e42 into release/v1.0.7 May 3, 2025
@MtMath MtMath deleted the fix/command-streaming branch May 3, 2025 02:48
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2025

🎉 This PR is included in version 1.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2025

🎉 This PR is included in version 1.0.7-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants