docs(fork): clear the pending release note shipped in v0.1.6 - #34
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Thermo-nuclear code quality review
No major structural issues found.
This PR only clears a single pending release-note entry from .fork/notes/RELEASE-NOTES-PENDING.md and leaves (none pending). That matches the file's own instruction after the prompt-stash warning shipped in the v0.1.6 release notes. No code, abstractions, branching, or layer boundaries are involved — nothing in the thermo-nuclear rubric applies.
Sent by Cursor Automation: Thermo-nuclear PR review
Review: the change is correct, but it retires a warning that is still liveVerdict on the diff: correct — merge it. I verified the claim rather than taking it on trust:
So the bookkeeping is honest. My findings are all about what the deletion leaves behind. 1. The hazard is not release-scoped, but the warning now isThis is the one I would act on before merging. The purge in baseStashStorage.removeItem(LEGACY_PROMPT_STASH_STORAGE_KEY);A user sitting on v0.1.5 today who skips v0.1.6 — it's a prerelease, and The file's instruction assumes obligations expire after one release. This one doesn't: it expires when the last install at or below v0.1.5 is gone. Retiring it after a single prerelease drops the warning for precisely the population it exists for. Concrete fix, with an in-repo precedent: put the line in the workflow template where the other durable upgrade warning already lives. 2. The queue has no reader
This queue worked exactly once, because the session that cut v0.1.6 happened to remember its own note from an hour earlier. Nothing would have caught the miss, and nothing will catch the next one. A file whose entire value is "someone reads this at release time" needs either a line in 3. The rationale is deleted rather than relocatedWhat's being removed isn't only a to-do. It is the only in-repo record of a user-visible data-loss event: which release, which storage key, the quota rationale, and the PR that caused it. After this merges, That knowledge now lives solely in a GitHub release body: mutable, unversioned, and not greppable from a checkout. The fork already has the right pattern — 4.
|
The purge of the legacy prompt-stash storage key fires on first launch of any build at v0.1.6 or later, not only on the v0.1.6 upgrade itself, so a user skipping the prerelease and jumping v0.1.5 -> v0.1.7 loses stashed prompts with no warning anywhere. Put the warning in the release body template next to the durable v0.1.1 userdata warning, where it rides every release until installs at or below v0.1.5 no longer matter. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Landed the review's finding 1 in fa14af1: the prompt-stash upgrade warning now rides every release body in Findings 2–4 (the pending-notes queue having no reader, relocating the incident rationale, the 🤖 Generated with Claude Code |


The prompt-stash data-loss warning queued in
.fork/notes/RELEASE-NOTES-PENDING.mdis now in the v0.1.6 release notes, so the pending entry comes out per that file's own instruction.🤖 Generated with Claude Code