Skip to content

Ping handling upgrade#198

Merged
mpetrunic merged 4 commits into
devfrom
mmuftic/fix-ping
Feb 24, 2021
Merged

Ping handling upgrade#198
mpetrunic merged 4 commits into
devfrom
mmuftic/fix-ping

Conversation

@MakMuftic
Copy link
Copy Markdown
Member

@MakMuftic MakMuftic commented Feb 24, 2021 •
edited
Loading

Few minor changes to improve handling pings

PR Checklist

  • I have run linter localy
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master
  • Updated CHANGELOG.md

Changes

  • Add check if two (or more) pings come one after other, this happens if one ping gets stuck in the network -> there is no need to add double downtime
  • Expand buffer for pings, from 5 + 5 seconds to 5 + 8 seconds (we will monitor this further)
  • Add additional logs for currently active nodes

@MakMuftic MakMuftic marked this pull request as ready for review February 24, 2021 12:20
@mpetrunic mpetrunic merged commit dfce573 into dev Feb 24, 2021
@mpetrunic mpetrunic deleted the mmuftic/fix-ping branch February 24, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

+1 more reviewer

@mpetrun5 mpetrun5 mpetrun5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MakMuftic @mpetrunic @mpetrun5