Fix#2
Merged
MakMuftic merged 4 commits intoMar 8, 2021
Merged
Conversation
dOrgJelli
commented
Mar 8, 2021
Comment on lines
+117
to
+119
| const oldData = data; | ||
| data = new Uint8Array(newLength); | ||
| data.set(oldData); |
Collaborator
Author
There was a problem hiding this comment.
This is what was broken when sending subinvoke result data back to the thread.
MakMuftic
reviewed
Mar 8, 2021
|
|
||
| let config: AxiosRequestConfig = { | ||
| responseType: request.responseType == "BINARY" ? "arraybuffer" : "text", | ||
| responseType: request.responseType == ResponseType.BINARY ? "arraybuffer" : "text", |
Member
There was a problem hiding this comment.
This won't work as enum from schema will be converted to a string.
Collaborator
Author
There was a problem hiding this comment.
This is not the case, enums are represented as integers when they're coming from Web3APIs. They're only (optionally) represented as strings when the client is sending an enum as an argument to a Web3API method.
MakMuftic
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main fix is in packages/js/client/src/wasm/thread.ts (see PR comment below)
Some additional things I did:
yarn test:env:up,yarn deploy,yarn testto see it all running and working.querymodule instead of amutationmodule, sincecatis a read only operation.getquery method instead ofpostmutation.ResponseTypeenum, now that it's supported :D (thank you @mpetrun5 👏)