Skip to content

Issue #31 : Need a descriptive error message if node settings are not correctly configured #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomotaro1065 merged 1 commit into from
May 13, 2013
Merged

Issue #31 : Need a descriptive error message if node settings are not correctly configured #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions org.nodeclipse.debug/src/org/nodeclipse/debug/launch/LaunchConfigurationDelegate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
import org.eclipse.debug.core.ILaunchManager;
import org.eclipse.debug.core.model.ILaunchConfigurationDelegate;
import org.eclipse.debug.core.model.RuntimeProcess;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.preference.PreferenceDialog;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Shell;
import org.eclipse.ui.PlatformUI;
import org.eclipse.ui.dialogs.PreferencesUtil;
import org.nodeclipse.debug.util.Constants;
import org.nodeclipse.debug.util.NodeDebugUtil;
import org.nodeclipse.ui.Activator;
Expand All @@ -43,10 +49,20 @@ public void launch(ILaunchConfiguration configuration, String mode,
}

// Using configuration to build command line

String nodePath = Activator.getDefault().getPreferenceStore().getString(PreferenceConstants.NODE_PATH);

// Check if the node location is correctly configured
File nodeFile = new File(nodePath);
if(!nodeFile.exists()){
// If the location is not valid than show a dialog which prompts the user to goto the preferences page
showPreferencesDialog();
return;
}

List<String> cmdLine = new ArrayList<String>();
// Application path should be stored in preference.
cmdLine.add(Activator.getDefault().getPreferenceStore()
.getString(PreferenceConstants.NODE_PATH));
cmdLine.add(nodePath);
if (mode.equals(ILaunchManager.DEBUG_MODE)) {
cmdLine.add("--debug-brk=5858");
}
Expand Down Expand Up @@ -87,6 +103,23 @@ public void launch(ILaunchConfiguration configuration, String mode,
}
nodeProcess = process;
}

private void showPreferencesDialog() {
Display.getDefault().syncExec(new Runnable() {
public void run() {
Shell shell = PlatformUI.getWorkbench().getActiveWorkbenchWindow().getShell();

MessageDialog dialog = new MessageDialog(shell, "Nodeclipse", null, "Node.js runtime not correctly configured.\n\n"
+ "Please goto Window -> Prefrences -> Nodeclipse and configure the correct location", MessageDialog.ERROR, new String[] { "Open Prefrences ...", "Cancel" }, 0);
int result = dialog.open();
if (result == 0) {
PreferenceDialog pref = PreferencesUtil.createPreferenceDialogOn(shell, PreferenceConstants.PREFERENCES_PAGE, null, null);
if (pref != null)
pref.open();
}
}
});
}

public static void terminateNodeProcess() {
if(nodeProcess != null) {
Expand Down
2 changes: 2 additions & 0 deletions org.nodeclipse.ui/src/org/nodeclipse/ui/preferences/PreferenceConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,7 @@ public class PreferenceConstants {
public static final String EXPRESS_PATH = "express_pass";
public static final String EXPRESS_VERSION = "express_version";
public static final String COMPLETIONS_JSON_PATH = "completionsjson_path";
public static final String PREFERENCES_PAGE = "org.nodeclipse.ui.preferences.NodePreferencePage";


}