Skip to content

Pass environment by pointer instead of shared_ptr to executor #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmccrmck merged 2 commits into from
Apr 24, 2019
Merged

Pass environment by pointer instead of shared_ptr to executor #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986b549
Pass environment by pointer instead of shared_ptr to executor
tmccrmck Apr 23, 2019
3ce6eeb
Merge branch 'master' of github.com:NonStatic2014/onnxruntime into tr…
tmccrmck Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onnxruntime/hosting/executor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace hosting {

class Executor {
public:
Executor(std::shared_ptr<HostingEnvironment> hosting_env, std::string request_id) : env_(hosting_env),
Executor(HostingEnvironment* hosting_env, std::string request_id) : env_(hosting_env),
request_id_(std::move(request_id)),
using_raw_data_(true) {}

Expand All @@ -24,7 +24,7 @@ class Executor {
/* out */ onnxruntime::hosting::PredictResponse& response);

private:
std::shared_ptr<HostingEnvironment> env_;
HostingEnvironment* env_;
const std::string request_id_;
bool using_raw_data_;

Expand Down
2 changes: 1 addition & 1 deletion onnxruntime/hosting/http/predict_request_handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ void Predict(const std::string& name,

// Run Prediction
protobufutil::Status status;
Executor executor(env, context.request_id);
Executor executor(env.get(), context.request_id);
PredictResponse predict_response{};
status = executor.Predict(name, version, predict_request, predict_response);
if (!status.ok()) {
Expand Down