Simple func to adjust the time of DS3231 and add simple alarm func#87
Merged
awickert merged 4 commits intoNorthernWidget:masterfrom Feb 14, 2025
R-YaTian:simple-alarm
Merged
Simple func to adjust the time of DS3231 and add simple alarm func#87awickert merged 4 commits intoNorthernWidget:masterfrom R-YaTian:simple-alarm
awickert merged 4 commits intoNorthernWidget:masterfrom
R-YaTian:simple-alarm
Conversation
Member
|
Has anyone tested/confirmed this PR and its functionality since it was added almost two years ago? |
Contributor
Author
I tested it two years ago, and it works all fine. So I opened this PR. |
Member
|
Thanks for noting your test. It adds new functions but does not change existing ones. Therefore, in case it does not work, it should not break things that currently work. I am okay accepting without further testing, especially considering the huge delay! Thanks :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add func for set alarm1&2 by hour/minute...
Add simple func to adjust the time of DS3231 by DateTime info...