Skip to content

Conversation

@poseidon-rises
Copy link
Contributor

Add fish support with fish-lsp and fish_indent.

Rewrite of #807 using the new API as the original creator has stopped responding.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Aug 25, 2025

🚀 Live preview deployed from f66d077

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: languages/fish

Reruns: 1960

@horriblename
Copy link
Collaborator

I'll hold off on merging this till #1103 is merged

github-actions bot pushed a commit that referenced this pull request Sep 26, 2025
@github-actions github-actions bot deleted the languages/fish branch November 1, 2025 04:14
@poseidon-rises poseidon-rises restored the languages/fish branch November 21, 2025 21:20
@github-actions github-actions bot deleted the languages/fish branch December 1, 2025 04:42
@imnotpoz
Copy link
Contributor

v0.8 was merged, the PR's target branch should be set to main

@horriblename horriblename changed the base branch from v0.8 to main January 22, 2026 19:52
github-actions bot pushed a commit that referenced this pull request Jan 22, 2026
github-actions bot pushed a commit that referenced this pull request Jan 24, 2026
Add fish support with fish-lsp and fish_indent.
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One blocker, lgtm afterwards.

Co-authored-by: raf <raf@notashelf.dev>
github-actions bot pushed a commit that referenced this pull request Jan 26, 2026
NotAShelf
NotAShelf previously approved these changes Jan 27, 2026
github-actions bot pushed a commit that referenced this pull request Jan 27, 2026
@NotAShelf
Copy link
Owner

@poseidon-rises the CI is failing because Nix is failing to evaluate type = listOf enum (attrNames formats);. I believe it's supposed to be listOf (enum (...)) or otherwise it thinks listOf takes two args, which it doesn't. Good for a merge once the CI failures have been addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants