-
-
Notifications
You must be signed in to change notification settings - Fork 192
add vue support for ts_ls #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NotAShelf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes regarding the correctness of the implementation and some formatting nits.
I'm not opposed to merging, but we should probably avoid polluting the closure for TS users while they haven't opted in to use Vue explicitly. The vue_ls server addition is fine, but I believe the plugin should not be added by default. I for one never use Vue anymore, but this would pull the LSP anyway and subject me to more rebuilds & cache hits for no reason.
You'll also want to update the v0.9 changelog (in docs/release-notes) with an entry.
|
I've implemented the changes you requested. My bad on the formatting, I forgot to use alejandra instead of nixfmt. I'm pretty new to nix so bare with me if I make some silly mistakes or assumptions. ;^^ |
In this PR I've added support for vue in the ts_ls language server.
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.