[feat] 2/n Adding NVFP4 Humans& Quantization - #1967
Draft
kailash109 wants to merge 21 commits into
Draft
Conversation
…ate moe architecture spec to define emitted tensors
…tization schemes (todo: add nvfp4 recipe)
…fine entire customizable quantization configurations
…dd runtime env var setting for NVfp4 prep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building off of #1953 to support humans& nvfp4 recipe
Overview
The base quantization strategy is built off of the abstractions introduced in #1953
high_precision_last_layerscount, for now no shared expert in qwen-30b-a3b but this is part of the excluded modules)nvfp4_per_tokenonline MoE quantization vllm-project/vllm#48538 does not support EP, the patch does per-token nvfp4 quantization on each gpu after all-gathering across EP ranks and before combine inside vllm's FusedMoEKernel experts.apply()). Currently this works for EP runs but is really messy by patching private methods in vllm so I'll see if I can potentially upstream thisValidation
Tested working two full DAPO steps as well as extra test coverage for per-tensor global scales, four-over-six quantization, BF16 final-layer exclusions, vllm init + receiver mappins
Keeping in draft for now, waiting for correctness + step time perf results from e2e validation runs, as well as need to do a deeper review of the code