[chore][deps] Support GLM-5.2 configs - #1974
Open
bvolpato wants to merge 2 commits into
Open
Conversation
bvolpato
marked this pull request as ready for review
August 3, 2026 19:37
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency versions in pyproject.toml and docker/pyproject.amd.toml. Specifically, it upgrades transformers to version 5.11.0 (pinning it and removing platform restrictions in overrides) and updates peft from 0.18.1 to 0.19.1 across dependencies and training extras. There are no review comments, so I have no feedback to provide.
This was referenced Aug 3, 2026
Pin Transformers 5.11.0, first tested release accepting deepseek_sparse_attention layer types. Update PEFT for compatible adapter APIs and apply Transformers override on every platform.
bvolpato
force-pushed
the
bvolpato/transformers-5-11
branch
from
August 4, 2026 00:37
44eeae4 to
87ab3cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deepseek_sparse_attentionlayer typesWhy 5.11.0 instead of latest
This PR intentionally stops at 5.11.0:
GlmMoeDsaConfigwithout rewriting model configqwen3_asrKeeping first compatible release makes GLM config support available without bundling Megatron Bridge or CUDA wheel-source changes. Wider version ranges can follow once those conflicts are resolved.
Validation
uv lock --check--with transformers==5.2.0inference-optimization/GLM-5.2-0.8B-A0.8BBF16 SDPA load on RTX 5070 Ti12.4402to11.9881over five steps12.4953to11.3287; every gradient was finite0.7070,0.70710.0418,0.0448q_a_projLoRA-B matrices became nonzero17.6720to0.0127; every gradient was finiteThe local GLM rollout used a test-only vLLM dense MLA fallback because current sparse MLA kernels reject this checkpoint's 192-wide compressed KV head on SM120. At smoke-test sequence lengths below the model's
index_topk=2048, dense MLA attends the same complete prefix. Native long-context DSA support remains separate vLLM work and is not claimed by this PR.Megatron GPU and AMD runs were not available locally. Megatron-native GLM-5.2 support remains separate from this config/FSDP prerequisite.
0.6938over steps 1-4 to0.7147over steps 9-12, with expected sampling noise. Dense MLA requiredgenerator.inference_engine.enable_prefix_caching=falsebecause vLLM v0.23 compressed-cache gather kernels only accept head widths 320 or 576, not this model’s 192.