Fix billable-canary cache-source false-fail (srcOK accepts 'cache')#225
Merged
Conversation
…ary false-fail
Review round-4 minor (re-flagged 3x): the flag-off EPA canary's source predicate
srcOK omitted 'cache', yet BaseHybridClient.js:202 returns _hybrid_metadata.source='cache'
on a cache hit — so a cache hit on the BILLABLE flag-off control run would emit
'flag-off source not in {...}' and false-fail a paid run. The revise leg's own rationale
named cache as a real source but the committed predicate rejected it. Add ||s==='cache' to
the predicate + its error string + all 11 documented source-enum listings (additive; can't
break existing matches). plan.md re-rendered (certified header preserved). The one minor with
a real cost is now closed; remaining 8 are fix-in-flight/accept.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-4 minor with real cost: the flag-off EPA canary predicate omitted the cache hybrid source (BaseHybridClient.js:202), so a cache hit would false-fail a BILLABLE run. Add cache to the srcOK predicate + error string + all source-enum listings; plan.md re-rendered (certified header preserved).
🤖 Generated with Claude Code