Skip to content

schema test coverage: return code 1 if coverage is below 100%#109

Merged
lornajane merged 1 commit into
OAI:mainfrom
ralfhandl:schema-test-coverage-check
Mar 14, 2025
Merged

schema test coverage: return code 1 if coverage is below 100%#109
lornajane merged 1 commit into
OAI:mainfrom
ralfhandl:schema-test-coverage-check

Conversation

@ralfhandl

@ralfhandl ralfhandl commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

This will cause the schema-test workflow to fail if the schema test coverage drops.

Fixes #107

@lornajane

Copy link
Copy Markdown
Contributor

Adding some notes as I go along:

  • the action that runs this is schema-tests
  • that in turn runs npm test
  • tested it by removing enough tests to reduce the coverage number and confirming that npm test on the main branch returns exit code 0 but on this branch I get exit code 1 as described.

@lornajane lornajane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, a small but mighty change!

@lornajane lornajane merged commit 4078a24 into OAI:main Mar 14, 2025
@ralfhandl ralfhandl deleted the schema-test-coverage-check branch March 14, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

schema-tests workflow: fail if coverage drops below 100 percent

2 participants