Skip to content

[9.0][MIG] portal_claim: Renamed to website_crm_claim - #1021

Merged
pedrobaeza merged 1 commit into
OCA:9.0from
Tecnativa:9.0-mig_portal_claim
Aug 16, 2017
Merged

[9.0][MIG] portal_claim: Renamed to website_crm_claim#1021
pedrobaeza merged 1 commit into
OCA:9.0from
Tecnativa:9.0-mig_portal_claim

Conversation

@cubells

@cubells cubells commented Aug 14, 2017

Copy link
Copy Markdown
Member

Features are merged in crm_claim module

@cubells
cubells force-pushed the 9.0-mig_portal_claim branch 2 times, most recently from 81e27df to 24a87f4 Compare August 14, 2017 15:34
pedrobaeza
pedrobaeza requested changes Aug 15, 2017
View reviewed changes
Comment thread openerp/addons/base/migrations/9.0.1.3/pre-migration.py Outdated

@pedrobaeza pedrobaeza Aug 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the code at 8.0 and 9.0, it's better to just rename (in apriori.py) portal_claim to website_crm_claim

@cubells
cubells force-pushed the 9.0-mig_portal_claim branch from 24a87f4 to ebdb1a1 Compare August 16, 2017 07:25
MiquelRForgeFlow
MiquelRForgeFlow requested changes Aug 16, 2017
View reviewed changes
Comment thread addons/crm_claim/migrations/9.0.1.0/pre-migration.py Outdated

@MiquelRForgeFlow MiquelRForgeFlow Aug 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this else because, in this case, there would be nothing to unlink

@MiquelRForgeFlow

MiquelRForgeFlow commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

And please, update documentation

pedrobaeza
pedrobaeza reviewed Aug 16, 2017
View reviewed changes
Comment thread addons/crm_claim/migrations/9.0.1.0/pre-migration.py Outdated

@pedrobaeza pedrobaeza Aug 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore making the renaming in the other place. Please restore it as it was.

@cubells
cubells force-pushed the 9.0-mig_portal_claim branch from a4e964f to 7445194 Compare August 16, 2017 09:16
pedrobaeza
pedrobaeza reviewed Aug 16, 2017
View reviewed changes
Comment thread addons/crm_claim/migrations/9.0.1.0/pre-migration.py Outdated

@pedrobaeza pedrobaeza Aug 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm talking about leaving this as it was before this PR. You don't need to do this with the renaming of the module.

@MiquelRForgeFlow MiquelRForgeFlow Aug 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True 👍

@cubells
cubells force-pushed the 9.0-mig_portal_claim branch from 7445194 to f908ac6 Compare August 16, 2017 09:24
pedrobaeza
pedrobaeza reviewed Aug 16, 2017
View reviewed changes
Comment thread addons/crm_claim/migrations/9.0.1.0/pre-migration.py Outdated

@pedrobaeza pedrobaeza Aug 16, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're still modifying this script. Please restore it as it was for making the diff smaller.

@cubells
cubells force-pushed the 9.0-mig_portal_claim branch from f908ac6 to d3cf62b Compare August 16, 2017 10:46
@cubells

cubells commented Aug 16, 2017

Copy link
Copy Markdown
Member Author

You are right @pedrobaeza

Sorry.

@pedrobaeza pedrobaeza closed this Aug 16, 2017
@pedrobaeza pedrobaeza reopened this Aug 16, 2017
@pedrobaeza pedrobaeza changed the title [9.0][MIG] portal_claim: merged in crm_claim [9.0][MIG] portal_claim: Rename to website_crm_claim Aug 16, 2017
@pedrobaeza pedrobaeza changed the title [9.0][MIG] portal_claim: Rename to website_crm_claim [9.0][MIG] portal_claim: Renamed to website_crm_claim Aug 16, 2017
@pedrobaeza

pedrobaeza commented Aug 16, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Agh, I miss to say to you about the documentation... Please put Done - Renamed to website_crm_claim

@pedrobaeza pedrobaeza mentioned this pull request Aug 16, 2017
Closed
@pedrobaeza

pedrobaeza commented Aug 16, 2017

Copy link
Copy Markdown
Member

And you have to fill also website_crm_claim line with Done - Renamed from portal_claim

@cubells
cubells force-pushed the 9.0-mig_portal_claim branch from d3cf62b to 383bf77 Compare August 16, 2017 11:17
@pedrobaeza
pedrobaeza merged commit 564f9ea into OCA:9.0 Aug 16, 2017
@pedrobaeza
pedrobaeza deleted the 9.0-mig_portal_claim branch August 16, 2017 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes
@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cubells @MiquelRForgeFlow @pedrobaeza