[9.0][ADD] account_invoice_reorder_lines - #1210
Merged
StefanRijnhart merged 2 commits intoDec 5, 2017
Merged
Conversation
The feature has been included now in core. The field sequence already existed in 8, but the _order was not set. Now that order has been set, and the field name is the same, so nothing more to do, except merging the module for avoiding a missing module message.
pedrobaeza
changed the title
Contributor
|
Thus, you should delete the module from |
Member
Author
|
Uhm, I see, but why have you continued with that module if core makes already the order? Can you ask in your company? |
Contributor
|
Some people like to migrate things like a hobby. I will ask to @aheficent |
|
@pedrobaeza You're are right. But we also need to see the sequence number in the view because it's easier in invoices with many invoice lines. Perhaps the module should be refactored and only show the sequence number in the view. |
Member
Author
|
But then it should be optional to install that additional feature. People coming from the old v8 module only need core. I will remove the apriori reference then. |
Member
Author
|
I have removed the other reference. Please squash on merge. |
MiquelRForgeFlow
approved these changes
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature has been included now in core. The field sequence already existed in 8, but the _order was not set. Now that order has been set, and the field name is the same, so nothing more to do, except merging the module for avoiding a missing module message.
@Tecnativa