[MIG][10.0] purchase_requisition: migration scripts - #1403
Merged
Conversation
cubells
force-pushed
the
10.0-mig-purchase_requisition
branch
2 times, most recently
from
June 25, 2018 13:39
ff4a231 to
868d7d5
Compare
pedrobaeza
requested changes
Jun 25, 2018
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
flake8 error:
./addons/purchase_requisition/migrations/10.0.0.1/post-migration.py:5:1: F401 'psycopg2.extensions.AsIs' imported but unuse
Member
There was a problem hiding this comment.
You should leave it blank, as it's not required and you can have quotations from several vendors. This is a new feature for autocompleting new RfQs only.
Member
There was a problem hiding this comment.
You should assign to an existing product if null. Check if there's a product in standard that you can assign, and if not, you should create a new one
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cubells
force-pushed
the
10.0-mig-purchase_requisition
branch
4 times, most recently
from
June 28, 2018 15:50
4bb884f to
81e577c
Compare
pedrobaeza
force-pushed
the
10.0-mig-purchase_requisition
branch
from
June 28, 2018 19:41
81e577c to
09eb5d6
Compare
pedrobaeza
force-pushed
the
10.0-mig-purchase_requisition
branch
from
June 28, 2018 20:28
09eb5d6 to
0ef10f9
Compare
pedrobaeza
approved these changes
Jun 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa