Skip to content

[10.0] sale_margin : nothing to do - #1646

Merged
pedrobaeza merged 1 commit into
10.0from
legalsylvain-patch-2
Dec 4, 2018
Merged

[10.0] sale_margin : nothing to do#1646
pedrobaeza merged 1 commit into
10.0from
legalsylvain-patch-2

Conversation

@legalsylvain

Copy link
Copy Markdown
Contributor

mark as nothing to do sale_margin.

Don't know why the migration folder is not present, but the two simple modules are indentical. (just migrated into new API).

V9 : https://github.com/odoo/odoo/blob/9.0/addons/sale_margin/sale_margin.py
V10 : https://github.com/odoo/odoo/blob/10.0/addons/sale_margin/models/sale_order.py

@legalsylvain legalsylvain added this to the 10.0 milestone Dec 4, 2018
@pedrobaeza

pedrobaeza commented Dec 4, 2018

Copy link
Copy Markdown
Member

There's no migrations folder because there isn't any change. It's created when there's any change and openupgrade_analysis.txt file has to be created.

@pedrobaeza

Copy link
Copy Markdown
Member

Please avoid to make the patch directly on OCA branch as this triggers 2 Travis builds that are very heavy.

@legalsylvain

Copy link
Copy Markdown
Contributor Author

Please avoid to make the patch directly on OCA branch as this triggers 2 Travis builds that are very heavy.

yes sorry. It occures when I use the github interface. Do you know how to force github to create the branch in /legalsylvain instead of OpenUpgrade ?

regards.

@pedrobaeza

Copy link
Copy Markdown
Member

I'm afraid GitHub doesn't offer this for now, only to change email address for committing.

@pedrobaeza
pedrobaeza merged commit d40be57 into 10.0 Dec 4, 2018
@OCA-git-bot
OCA-git-bot deleted the legalsylvain-patch-2 branch December 4, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants