[FIX] apriori incorrect rename (product_supplierinfo_for_customer_sale) - #1813
Merged
pedrobaeza merged 2 commits intoMay 1, 2019
Merged
Conversation
Member
|
Please move it instead to |
Contributor
Author
|
done. Thanks for your insight. |
pedrobaeza
approved these changes
May 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
This is due to the apriori.py file from openupgrade 10.0 that mentions that the module
product_customer_code_salehas been renamed intoproduct_supplierinfo_for_customer_saleThe problem is that
product_supplierinfo_for_customer_saleexists in V8, so the module is present inir_module_moduletable (OCA/product-attribute/8.0) https://github.com/OCA/product-attribute/tree/8.0/product_supplierinfo_for_customer_saleproduct_customer_code_saleexists in V8, so the module is also present inir_module_moduletable. (OCA/sale-workflow/8.0) https://github.com/OCA/sale-workflow/tree/8.0/product_customer_code_saleI don't know if this is the best solution, but it seems that the current code is not correct, so I disabled the line.
regards.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr