Skip to content

[9.0][ADD] purchase_double_validation: Migration scripts - #2137

Merged
OCA-git-bot merged 1 commit into
OCA:9.0from
Tecnativa:9.0-purchase_double_validation
Dec 20, 2019
Merged

[9.0][ADD] purchase_double_validation: Migration scripts#2137
OCA-git-bot merged 1 commit into
OCA:9.0from
Tecnativa:9.0-purchase_double_validation

Conversation

@pedrobaeza

Copy link
Copy Markdown
Member

@Tecnativa TT20683

@pedrobaeza pedrobaeza added this to the 9.0 milestone Dec 19, 2019
@pedrobaeza
pedrobaeza force-pushed the 9.0-purchase_double_validation branch 2 times, most recently from cfb956c to 7246b27 Compare December 19, 2019 22:45
@StefanRijnhart

Copy link
Copy Markdown
Member

Unexpected travis error

File "/home/travis/build/OCA/OpenUpgrade/addons/purchase/migrations/9.0.1.2/post-migration.py", line 303, in migrate_purchase_double_validation

    words = env.ref('purchase.trans_confirmed_double_gt').condition.split()

  File "/home/travis/build/OCA/OpenUpgrade/openerp/api.py", line 792, in ref

    return self['ir.model.data'].xmlid_to_object(xml_id, raise_if_not_found=raise_if_not_found)

  File "/home/travis/build/OCA/OpenUpgrade/openerp/api.py", line 248, in wrapper

    return new_api(self, *args, **kwargs)

  File "/home/travis/build/OCA/OpenUpgrade/openerp/api.py", line 490, in new_api

    result = method(self._model, cr, uid, *args, **old_kwargs)

  File "/home/travis/build/OCA/OpenUpgrade/openerp/addons/base/ir/ir_model.py", line 1049, in xmlid_to_object

    raise ValueError('No record found for unique ID %s. It may have been deleted.' % (xmlid))

ValueError: No record found for unique ID purchase.trans_confirmed_double_gt. It may have been deleted.

Comment thread openerp/openupgrade/doc/source/modules80-90.rst Outdated
@pedrobaeza
pedrobaeza force-pushed the 9.0-purchase_double_validation branch from 7246b27 to d93c0f6 Compare December 20, 2019 15:30
@pedrobaeza
pedrobaeza force-pushed the 9.0-purchase_double_validation branch from d93c0f6 to ae98d98 Compare December 20, 2019 19:28
@pedrobaeza

Copy link
Copy Markdown
Member Author

Fixed. Workflow is being deleted before, so I need to take the value on pre before this removal.

@StefanRijnhart StefanRijnhart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@StefanRijnhart

Copy link
Copy Markdown
Member

/ocabot merge

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 9.0-ocabot-merge-pr-2137-by-StefanRijnhart-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Dec 20, 2019
Signed-off-by StefanRijnhart
@OCA-git-bot
OCA-git-bot merged commit ae98d98 into OCA:9.0 Dec 20, 2019
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at bef5441. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 9.0-purchase_double_validation branch November 18, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants