Skip to content

[13.0][OU-IMP] point_of_sale: stock_location_id - #3537

Merged
pedrobaeza merged 1 commit into
OCA:13.0from
Tecnativa:13.0-ou-point_of_sale-stock_location_id
Aug 25, 2022
Merged

[13.0][OU-IMP] point_of_sale: stock_location_id#3537
pedrobaeza merged 1 commit into
OCA:13.0from
Tecnativa:13.0-ou-point_of_sale-stock_location_id

Conversation

@chienandalu

Copy link
Copy Markdown
Member

In v13 the deafault location of the picking type is used to take the stock in the picking operations of the pos configs. In the migration, this can lead to pickings that were using a common operation type taking the stock from the wrong locations. We prevent it creating new picking types for that configs.

cc @Tecnativa TT23199

@chienandalu
chienandalu force-pushed the 13.0-ou-point_of_sale-stock_location_id branch from 797cb20 to 37c618e Compare August 23, 2022 13:04

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks.

Comment thread addons/point_of_sale/migrations/13.0.1.0.1/pre-migration.py Outdated
@chienandalu
chienandalu force-pushed the 13.0-ou-point_of_sale-stock_location_id branch from 37c618e to 7c04243 Compare August 23, 2022 13:40
@chienandalu
chienandalu marked this pull request as ready for review August 23, 2022 13:42
@chienandalu
chienandalu force-pushed the 13.0-ou-point_of_sale-stock_location_id branch 3 times, most recently from 42f5242 to 4bf1d9c Compare August 24, 2022 06:45
@chienandalu

Copy link
Copy Markdown
Member Author

Ready for review @MiquelRForgeFlow @pedrobaeza

Comment thread addons/point_of_sale/migrations/13.0.1.0.1/post-migration.py Outdated
@pedrobaeza pedrobaeza changed the title [13.0][OU] point_of_sale: stock_location_id [13.0][OU-IMP] point_of_sale: stock_location_id Aug 24, 2022

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message tag is [OU-IMP] or [OU-FIX], not only [OU]

Comment thread addons/point_of_sale/migrations/13.0.1.0.1/pre-migration.py Outdated
Comment thread addons/point_of_sale/migrations/13.0.1.0.1/post-migration.py Outdated
@chienandalu
chienandalu force-pushed the 13.0-ou-point_of_sale-stock_location_id branch from 4bf1d9c to 715584c Compare August 24, 2022 10:53
@MiquelRForgeFlow

Copy link
Copy Markdown
Contributor

Please, document the change in the openupgrade_analysis_work.txt file.

@chienandalu
chienandalu force-pushed the 13.0-ou-point_of_sale-stock_location_id branch from 715584c to 4cd743e Compare August 24, 2022 11:14
@chienandalu

Copy link
Copy Markdown
Member Author

Changes done

Comment thread addons/point_of_sale/migrations/13.0.1.0.1/openupgrade_analysis_work.txt Outdated
In v13 the deafault location of the picking type is used to take the
stock in the picking operations of the pos configs. In the migration,
this can lead to pickings that were using a common operation type taking
the stock from the wrong locations. We prevent it creating new picking
types for that configs.

TT23199
@chienandalu
chienandalu force-pushed the 13.0-ou-point_of_sale-stock_location_id branch from 4cd743e to 0331f29 Compare August 25, 2022 07:17
@pedrobaeza
pedrobaeza merged commit dba45a6 into OCA:13.0 Aug 25, 2022
@pedrobaeza
pedrobaeza deleted the 13.0-ou-point_of_sale-stock_location_id branch August 25, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants