Skip to content

[16.0][OU-ADD] hr_contract - #3912

Closed
remytms wants to merge 1 commit into
OCA:16.0from
coopiteasy:16-add-hr_contract
Closed

[16.0][OU-ADD] hr_contract#3912
remytms wants to merge 1 commit into
OCA:16.0from
coopiteasy:16-add-hr_contract

Conversation

@remytms

@remytms remytms commented Jun 13, 2023

Copy link
Copy Markdown

Most of the changes are managed by the migration script of hr module. Load the noupdate_changes file.

Most of the changes are managed by the migration script of hr module.
Load the noupdate_changes file.
@legalsylvain

legalsylvain commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

/ocabot migration hr_contract

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jun 13, 2023
@remytms
remytms marked this pull request as ready for review June 13, 2023 18:35
@remytms remytms changed the title [OU-ADD] hr_contract [16.0][OU-ADD] hr_contract Jun 13, 2023

@marielejeune marielejeune left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@andreampiovesana

Copy link
Copy Markdown

merge?

@remytms

remytms commented Jan 19, 2024

Copy link
Copy Markdown
Author

I think that it will be merge when dependencies will be scripted and merged.

@remytms

remytms commented Feb 19, 2024

Copy link
Copy Markdown
Author

@legalsylvain I think this is not blocked by dependency anymore, since the merge of module hr.


@openupgrade.migrate()
def migrate(env, version):
openupgrade.load_data(env.cr, "hr_contract", "16.0.1.0/noupdate_changes.xml")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyzing noupdate_changes.xml file, the group_hr_contract_manager is being modified through (4, id), which means that the previous content is kept, and we don't want this, so you should add first a (5, ) command for erasing current content.

@pedrobaeza

Copy link
Copy Markdown
Member

Superseded by #4336 for adding the missing piece.

@pedrobaeza pedrobaeza closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants