[16.0][OU-ADD] hr_holidays - #3913
Closed
remytms wants to merge 1 commit into
Closed
Conversation
Member
|
/ocabot migration hr_holidays |
pedrobaeza
reviewed
Jun 13, 2023
remytms
force-pushed
the
16-add-hr_holidays
branch
2 times, most recently
from
June 14, 2023 14:24
bc590d7 to
f309dd4
Compare
remytms
marked this pull request as ready for review
June 14, 2023 14:25
This was referenced Jul 3, 2023
1 task
Compute new values for allocation_validation_type on hr.leave.type as it is now a stored computed field with only two choices: "no" and "officer". Load noupdate_changes.
remytms
force-pushed
the
16-add-hr_holidays
branch
from
February 19, 2024 14:06
f309dd4 to
a7ff989
Compare
pedrobaeza
requested changes
Feb 24, 2024
| It set "no" by default except if employee_request is set to "no" | ||
| where it set "officer". | ||
| """ | ||
| openupgrade.logged_query( |
Member
There was a problem hiding this comment.
You only need to reallocate those with set value to the corresponding one. Please don't write the rest that are OK.
Member
There was a problem hiding this comment.
As further explanation, imagine there's an extra module adding a new validation type. You are overwriting the leave types with this new validation type in this SQL.
Member
|
Superseded by #4335 correcting the SQL query about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute new values for allocation_validation_type on hr.leave.type as it is now a stored computed field with only two choices: "no" and "officer".
Load noupdate_changes.