[15.0][OU-IMP] website: extract footer copyright company name - #4097
Merged
pedrobaeza merged 1 commit intoJul 25, 2023
Merged
Conversation
pedrobaeza
reviewed
Jul 20, 2023
pilarvargas-tecnativa
force-pushed
the
15.0-ou-add-website-footer_copyright_company_name
branch
4 times, most recently
from
July 25, 2023 09:17
27b1022 to
771580d
Compare
pedrobaeza
approved these changes
Jul 25, 2023
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Tested in a real migration
pedrobaeza
requested changes
Jul 25, 2023
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Wait, not really. Reviewing.
TT44254 Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>
pedrobaeza
force-pushed
the
15.0-ou-add-website-footer_copyright_company_name
branch
from
July 25, 2023 21:51
771580d to
92cb554
Compare
pedrobaeza
changed the title
pedrobaeza
approved these changes
Jul 25, 2023
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
Now it's adjusted. The problem was that the view may exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In versions prior to v15 the company name included in the copyright was done in a copy of the website.layout template. Now in v15 it is done in a new template that adds the content website.footer_copyright_company_name. This migration script is intended to extract the content of the old copyright and bring it into the new template.
cc @Tecnativa TT44254
@pedrobaeza please review :)