Skip to content

[16.0][OU-ADD] sale_expense: apply noupdate changes - #4292

Closed
robinkeunen wants to merge 1 commit into
OCA:16.0from
coopiteasy:v16_mig_sale_expense
Closed

[16.0][OU-ADD] sale_expense: apply noupdate changes#4292
robinkeunen wants to merge 1 commit into
OCA:16.0from
coopiteasy:v16_mig_sale_expense

Conversation

@robinkeunen

@robinkeunen robinkeunen commented Feb 1, 2024

Copy link
Copy Markdown

superseeds #4030

Blocked by dependency

@remytms remytms left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@MiquelRForgeFlow MiquelRForgeFlow added this to the 16.0 milestone Feb 15, 2024
@andreampiovesana

Copy link
Copy Markdown

merge?

@pedrobaeza pedrobaeza changed the title [OU-ADD] sale_expense: apply noupdate changes [16.0][OU-ADD] sale_expense: apply noupdate changes Mar 10, 2024
@pedrobaeza

Copy link
Copy Markdown
Member

I think it's too risky to change the policies of the existing products. It's OK to have that new defaults in a fresh v16 DB, but not to switch them when coming from v15, as they will behave different when migrating. Please comment the content on the noupdate_changes.xml file including these reflections.

@marielejeune

Copy link
Copy Markdown

Hi @robinkeunen, do you plan to apply Pedro's suggestion?

@robinkeunen

Copy link
Copy Markdown
Author

@marielejeune I won't have time in April. Feel free to superseed.

@pedrobaeza

Copy link
Copy Markdown
Member

Superseded by #4411

@pedrobaeza pedrobaeza closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants