Simplify migration calling, fix breakpoint use - #50
Merged
Conversation
Member
|
👍 the reason they do it that clumsily is that back in the days we had modules in zip files. That's not an issue for openupgrade |
Author
|
@hbrunn The real issue was |
Member
|
Really good, thanks! As this is core code, could you mark this code area with a comment mentioning OpenUpgrade andd the reason it is changed? |
Contributor
|
Agree with @StefanRijnhart remarks. 👍 otherwise. |
Author
|
Comments added |
Don't write to a temp file Use `load_module` instead of `load_source` This allows the use of breakpoints in IDEs and in pdb Signed-off-by: Sandy Carter <sandy.carter@savoirfairelinux.com>
hbrunn
added a commit
that referenced
this pull request
Jun 4, 2014
Simplify migration calling, fix breakpoint use
GuillemCForgeFlow
pushed a commit
to ForgeFlow/OpenUpgrade
that referenced
this pull request
Oct 10, 2024
Update module field in ir_model_fields when calling rename_models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't write to a temp file
Use
load_moduleinstead ofload_sourceThis allows the use of breakpoints in IDEs and in pdb
Signed-off-by: Sandy Carter sandy.carter@savoirfairelinux.com