[18.0][IMP] add a github workflow that generates test databases used in CI#5375
Conversation
My bad. It looks like I have destroyed this page, without having updated the new documentation : https://github.com/OCA/OpenUpgrade/wiki/_compare/d88c28abd294626b684fc6360561218c173d1287 |
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
Some remarks inline.
Otherwise, very great improvment ! thanks !
c959a0a to
d433891
Compare
d433891 to
d99969c
Compare
d99969c to
6b358b7
Compare
|
@hbrunn. is this PR ready to merge ? |
|
I think so, but lacking reviews |
|
@pedrobaeza, @MiquelRForgeFlow, @sergiocorato Could you take a time to review ? |
sergiocorato
left a comment
sergiocorato
left a comment
There was a problem hiding this comment.
I don't see anything wrong, but I'm not very familiar with gh.
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Nice!
/ocabot merge nobump
|
What a great day to merge this nice PR. Let's do it! |
|
@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-5375-by-StefanRijnhart-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Don't see the error. Should I merge manually? 
|
|
ocabot might be choking on the skipped workflow? manual merge would be very appreciated! |
5 participants
In #5370 I claimed that #5355 not failing in CI is because the test databases don't include translations, but that's wrong. Anyways, I spent the morning writing this workflow to have tests databases regenerated regularly, that's a good thing to have in its own right, as there are relevant changes from time to time which might break existing scripts.
You can inspect the results in https://github.com/hbrunn/OpenUpgrade/releases/tag/databases
Fixes #5370