[19.0][OU-ADD] l10n_es: Migration scripts#5646
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
73df3e4 to
9475506
Compare
hbrunn
left a comment
hbrunn
left a comment
There was a problem hiding this comment.
can't judge this functionally, but technically looks correct
9475506 to
024e446
Compare
|
I was missing the entry in the coverage file. Done |
|
/ocabot migration l10n_es |
legalsylvain
added
Blocked by dependency
Dependency OK
and removed
Blocked by dependency
labels
| DEL account.account.tag: l10n_es.account_tag_mod390_m774 | ||
| DEL account.account.tag: l10n_es.account_tag_mod390_m775 | ||
| DEL account.account.tag: l10n_es.account_tag_mod390_m776 | ||
|
|
There was a problem hiding this comment.
Don't put empty line here (and in the rest in a similar way)
|
|
||
| _xmlid_renames = [ | ||
| ( | ||
| "l10n_es_modelo130.mod_130", |
There was a problem hiding this comment.
This is not needed, as in any case, this should be done merging the modules, where the XML-ID renaming will take place, but the module l10n_es_modelo130 seems to be something that I'm not aware of. I don't see it on community. @hbrunn do you know where this comes from?
There was a problem hiding this comment.
Oh, found it: https://github.com/odoo/odoo/tree/18.0/addons/l10n_es_modelo130. Then definitively nothing more to do: https://github.com/OCA/OpenUpgrade/blob/19.0/openupgrade_scripts/apriori.py#L26
There was a problem hiding this comment.
Done. I have removed the rename. I assume that _xmlids_to_delete is still required, as it is not covered by the merging process.
c8dc11f to
caf6cf9
Compare
caf6cf9 to
4930235
Compare
5 participants
cc @Tecnativa TT58647
ping @pedrobaeza