Skip to content

[ADD] github action to check PR dependencies - #5745

Merged
pedrobaeza merged 2 commits into
OCA:19.0from
hbrunn:19.0-check-dependency-action
Jun 23, 2026
Merged

[ADD] github action to check PR dependencies#5745
pedrobaeza merged 2 commits into
OCA:19.0from
hbrunn:19.0-check-dependency-action

Conversation

@hbrunn

@hbrunn hbrunn commented Jun 23, 2026

Copy link
Copy Markdown
Member

this adds check_dependency.py from https://github.com/grap/openupgrade-extra-tools/tree/master as a github action that runs whenever one of the "Migration to version *" issues is edited (that is: whenever somebody says / ocabot migration something)

I've only added a very light touchup to make it easy to run the script as github action, this way you can keep running it manually if you want.

You can see this work in my test issue which refers to hbrunn#21, which was updated in the last run triggered by me editing the issue manually

@hbrunn
hbrunn requested a review from legalsylvain June 23, 2026 09:19
@legalsylvain

Copy link
Copy Markdown
Contributor

Hi. Thanks !

naive question :
in the bot message, it looks he did'nt found the related existing PR.

(Depends on :

base_setup : TODO
digest : TODO
phone_validation : TODO
resource_mail : TODO
web : TODO

)

@pedrobaeza pedrobaeza added this to the 19.0 milestone Jun 23, 2026
Comment thread .github/actions/check-pr-dependency/action.yml
@hbrunn

hbrunn commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

naive question : in the bot message, it looks he did'nt found the related existing PR.

yes, because it works on my repo and there the issue it looks at is https://github.com/hbrunn/OpenUpgrade/issues/22 which doesn't contain links to it. I just added one of them so that you see this works

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

@pedrobaeza
pedrobaeza merged commit 1823588 into OCA:19.0 Jun 23, 2026
7 checks passed
@legalsylvain

Copy link
Copy Markdown
Contributor

Note : side question, I'd like to give access to recurring contributors to have the right to write /ocabot migration even if they are not member of maintainers.
(I don't know exactly how).

Exemple : @pilarvargas-tecnativa who made 100 PR for exemple : https://github.com/OCA/OpenUpgrade/issues?q=is%3Apr+is%3Aopen+author%3A%40pilarvargas-tecnativa, and each time a maintainer has to write /ocabot ...

Do you think it could be relevant ?

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @legalsylvain. Your command failed:

Invalid options for command migration: .

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@pedrobaeza

Copy link
Copy Markdown
Member

I think it's better to simply add her to OpenUpgrade PSC.

@pedrobaeza

Copy link
Copy Markdown
Member

@hbrunn

hbrunn commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

yeah, this only works if you have push permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants