Skip to content

[MIG] procurement module migration scripts - #672

Merged
pedrobaeza merged 4 commits into
OCA:9.0from
Tecnativa:9.0-mig-procurement
Nov 25, 2016
Merged

[MIG] procurement module migration scripts#672
pedrobaeza merged 4 commits into
OCA:9.0from
Tecnativa:9.0-mig-procurement

Conversation

@cubells

@cubells cubells commented Nov 24, 2016

Copy link
Copy Markdown
Member

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

  • completed analysys
  • added analysis_work file

 * completed analysys
 * added analysis_work file
procurement / procurement.order / product_uos (many2one) : DEL relation: product.uom
procurement / procurement.order / product_uos_qty (float) : DEL
procurement / procurement.order / website_message_ids (one2many): NEW relation: mail.message
procurement / procurement.order / message_follower_ids (many2many) : not a function anymore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed this file?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add some analysis of fields/views that are missing in initial analysis.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things about this:

  • Don't change lines although the indentation is not so good for not increasing the diff.
  • Why they are not included? Maybe we should improve the analysis method. Anyway, don't include here that extra lines, but it _work file.

@pedrobaeza

Copy link
Copy Markdown
Member

@hbrunn hbrunn added this to the 9.0 milestone Nov 24, 2016
procurement / procurement.order / message_unread_counter (integer) : NEW
# New field ---> Nothing to do

procurement / procurement.order / product_uos (many2one) : DEL relation: product.uom

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this dissapears, maybe now product_uos and product_uos_qty of the sales orders are put directly in product_uom and product_uom_qty. If so, then you should include a script for copying "uos" values (in pre-migration) to "uom" when "uos" is present. Please check the behavior in v8 and v9 when you put sales units and tell me back.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not.

product_uos and product_uos_qty dissapear:
https://github.com/OCA/OpenUpgrade/blob/9.0/addons/sale/sale.py#L557
and product_uom is setted with product_uom and product_uom_qty.

I'm right?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, correct, then nothing to do on this.

|pos_restaurant | |
+-----------------------------------+-----------------------------------+
|procurement | |
|procurement | Done |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Done/Nothing to do

@pedrobaeza
pedrobaeza merged commit bc040b5 into OCA:9.0 Nov 25, 2016
@pedrobaeza
pedrobaeza deleted the 9.0-mig-procurement branch November 25, 2016 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants