Skip to content

[MIG] payment module migration script - #675

Merged
pedrobaeza merged 2 commits into
OCA:9.0from
Tecnativa:9.0-mig-payment
Nov 25, 2016
Merged

[MIG] payment module migration script#675
pedrobaeza merged 2 commits into
OCA:9.0from
Tecnativa:9.0-mig-payment

Conversation

@cubells

@cubells cubells commented Nov 24, 2016

Copy link
Copy Markdown
Member
  • Created openupgrade_analysis_work.txt
  • Updated module coverage document
  • Created pre-migration.py

@Tecnativa

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a required field, you need to fill this with something.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the inverse of this one2many? Was it already present in v8? If not, we should try to fill it heuristically. If yes, please add here apart from Nothing to do an explanation like Inverse field <x> was already present on v8

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to what?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to what?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/removed/added

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/removed/added

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the column is renamed, where is the line with the NEWentry? You should join both lines here in the work file.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I get it. You are renaming to preserve the columns in case of being needed. Then please put the text Column renamed to None to be preserved or something similar.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to fix

 * Created openupgrade_analysis_work.txt
 * Updated module coverage document
 * Created pre-migration.py

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, it's not correct. Please see Travis: https://travis-ci.org/OCA/OpenUpgrade/builds/178852352#L3131

@pedrobaeza
pedrobaeza merged commit 7a38ece into OCA:9.0 Nov 25, 2016
@pedrobaeza
pedrobaeza deleted the 9.0-mig-payment branch November 25, 2016 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants