[9.0][ADD] point_of_sale: Add script for migrate from v8 - #694
Merged
Conversation
sergio-teruel
force-pushed
the
9.0-PR-MIG-point_of_sale
branch
from
December 9, 2016 22:44
70d6d3b to
bf9ee29
Compare
hbrunn
requested changes
Dec 26, 2016
Member
There was a problem hiding this comment.
an env already knows its registry: https://github.com/OCA/OCB/blob/9.0/openerp/api.py#L753
Member
There was a problem hiding this comment.
This is exactly the case I have commented about old pool variables we need in OCA/openupgradelib#65
Member
There was a problem hiding this comment.
all of this could be a lot more efficient with a select...into statement, but given we don't expect a lot of pos configs, we don't really care I guess
Member
There was a problem hiding this comment.
As the operations are a bit complicated, we prefer to keep it as is, as the result SQL would be very difficult to read and maintain.
pedrobaeza
force-pushed
the
9.0-PR-MIG-point_of_sale
branch
from
December 27, 2016 18:33
f4929eb to
58c1215
Compare
pedrobaeza
force-pushed
the
9.0-PR-MIG-point_of_sale
branch
from
December 27, 2016 18:52
58c1215 to
3b58d84
Compare
Member
|
Comments fixed or replied, @hbrunn |
Member
|
@hbrunn, any objection on merging this? |
hbrunn
approved these changes
Jan 3, 2017
Member
|
no, go ahead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Migration script for Point_of_sale
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr