Skip to content

[FIX] Add move of xml_id's to im_livechat. - #737

Merged
pedrobaeza merged 2 commits into
OCA:9.0from
NL66278:9.0-im-livechat-xmlid
Jan 16, 2017
Merged

[FIX] Add move of xml_id's to im_livechat.#737
pedrobaeza merged 2 commits into
OCA:9.0from
NL66278:9.0-im-livechat-xmlid

Conversation

@NL66278

@NL66278 NL66278 commented Jan 13, 2017

Copy link
Copy Markdown

Description of the issue/feature this PR addresses: Migration crashes on duplicate group

Current behavior before PR: Migration crashed

Desired behavior after PR is merged: Migration succeeds

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza

Copy link
Copy Markdown
Member

Please update documentation marking im_livechat as "Done".

@NL66278

NL66278 commented Jan 16, 2017

Copy link
Copy Markdown
Author

@pedrobaeza Maybe I am a little bit foggy in my head due to a severe cold, but I can not quite find where to update this documentation.

@pedrobaeza

Copy link
Copy Markdown
Member

It's on https://github.com/OCA/OpenUpgrade/blob/9.0/openerp/openupgrade/doc/source/modules80-90.rst.

I can do it if you want.

I hope you'll get better soon.

@NL66278

NL66278 commented Jan 16, 2017

Copy link
Copy Markdown
Author

Please do. Thanks a lot! I checked the migration analysis and I really think only the rename of the xmlid's is needed, but I am not totally sure. But my primary purpose was that the migration should no longer crash.

@pedrobaeza

Copy link
Copy Markdown
Member

Done in this branch and merging when Travis finishes.

@pedrobaeza
pedrobaeza merged commit 338b2be into OCA:9.0 Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants