[ADD] mail

[hbrunn]

No description provided.

[StefanRijnhart]

Looks like a redundant check, given the next line?

[hbrunn]

I agree, but don't have my ssh keys at hand

[pedrobaeza]

Please attend this comment and we are good to go with this PR.

[hbrunn]

done

[StefanRijnhart]

Loading noupdate data here: hbrunn#2

[StefanRijnhart]

What, no env? hbrunn#3
But really, you might want to refactor to use env everywhere (or specify use_env=False) because we planned for the decorator to return an env by default in version 10.
-- edit: included in the PR --

[hbrunn]

I thought we only wanted to default to an env in 11? I'd like to stick to the cr version as soon as it's the default and I only use cursors anyways
If we want to change the default in openupgradelib, let's do that now

[StefanRijnhart]

Ah, that explains. Docstring says 'Starting from version 10, this is the default', but the code says > 10.

[StefanRijnhart]

Let's do it now https://github.com/OCA/openupgradelib/pull/69/files

[StefanRijnhart]

While you are here, could you confirm that this line is redundant? #790 (diff)

[pedrobaeza]

Curious mechanism that Odoo has used with _table = 'mail_message_res_partner_needaction_rel' for keeping the same many2many table, but it makes things simpler.

[pedrobaeza]

Don't change in this PR other modules doc

[hbrunn]

this was my judgement of the dependencies, but your PR says otherwise

[pedrobaeza]

Well, it can be barely consider as nothing to do, as this is only have side-effects sometimes, but I prefer to stay safe with the previous known issues. Anyway, my comment was for isolating this kind of changes from PR with the scripts of one module. We can make a PR for these changes, or directly a commit including this documentation (as it doesn't affect Travis status and thus doesn't require even optimistic merging).